Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BD-46] docs: added link to Contrast Checker tool #2726

Merged
merged 2 commits into from
Oct 26, 2023
Merged

[BD-46] docs: added link to Contrast Checker tool #2726

merged 2 commits into from
Oct 26, 2023

Conversation

PKulkoRaccoonGang
Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang commented Oct 18, 2023 •
edited
Loading

Description

  • added link to Contrast Checker tool;
  • added segment event.

Issue: #2647

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 18, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 18, 2023 •
edited
Loading

Thanks for the pull request, @PKulkoRaccoonGang!

When this pull request is ready, tag your edX technical lead.

@netlify
Copy link

netlify bot commented Oct 18, 2023 •
edited
Loading

✅ Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2531acc
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/653154a99183240008d2344f
😎 Deploy Preview https://deploy-preview-2726--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PKulkoRaccoonGang PKulkoRaccoonGang mentioned this pull request Oct 18, 2023
Closed
@PKulkoRaccoonGang PKulkoRaccoonGang changed the title []BD-46 docs: added link to Contrast Checker tool [BD-46] docs: added link to Contrast Checker tool Oct 18, 2023
@openedx-webhooks openedx-webhooks added blended PR is managed through 2U's blended developmnt program and removed open-source-contribution PR author is not from Axim or 2U labels Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (98f7822) 92.82% compared to head (2531acc) 92.82%.
Report is 6 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2726   +/-   ##
=======================================
  Coverage   92.82%   92.82%           
=======================================
  Files         235      235           
  Lines        4237     4237           
  Branches     1029     1029           
=======================================
  Hits         3933     3933           
  Misses        300      300           
  Partials        4        4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@viktorrusakov viktorrusakov linked an issue Oct 19, 2023 that may be closed by this pull request
Resource for a11y color contrast validation #2647
Closed
@viktorrusakov
Copy link
Contributor

@PKulkoRaccoonGang also please update confluence doc with new event after we merge this.

@viktorrusakov viktorrusakov merged commit df30702 into openedx:master Oct 26, 2023
8 checks passed
@openedx-webhooks
Copy link

@PKulkoRaccoonGang 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@openedx-semantic-release-bot
Copy link

🎉 This PR is included in version 21.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@PKulkoRaccoonGang PKulkoRaccoonGang mentioned this pull request Nov 6, 2023
Closed
@openedx-semantic-release-bot
Copy link

🎉 This PR is included in version 22.0.0-alpha.15 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viktorrusakov viktorrusakov viktorrusakov approved these changes

@adamstankiewicz adamstankiewicz Awaiting requested review from adamstankiewicz

@monteri monteri Awaiting requested review from monteri

Assignees
No one assigned
Labels
blended PR is managed through 2U's blended developmnt program released on @alpha released
Projects
Contributions
Status: Done
2U Blended Project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resource for a11y color contrast validation
4 participants
@PKulkoRaccoonGang @openedx-webhooks @viktorrusakov @openedx-semantic-release-bot